fix: improve call validation by checking validation of form using native html input before changing step #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolmsten
requested review from
mehta-pooja123 and
janosbabik
and removed request for
a team
janosbabik
requested changes
Nov 12, 2024
| @@ -51,9 +51,17 @@ export const Wizard = ({ | |||
| setStepNumber(Math.max(stepNumber - 1, 0)); | |||
| }; | |||
|
|
|||
| const handleStep = (step: number, values: FormikValues) => () => { | |||
| const handleStep = (stepIndex: number, values: FormikValues) => async () => { | |||
There was a problem hiding this comment.
Suggested change
| const handleStep = (stepIndex: number, values: FormikValues) => async () => { | |
| const handleStep = (stepIndex: number, values: FormikValues) => () => { |
TCMeldrum
approved these changes
Nov 20, 2024
janosbabik
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves call validation by checking the validation of the form using native HTML input before changing the step.
Motivation and Context
This change is necessary to ensure the user has correctly filled out the form before proceeding to the next step. This will prevent submission of incomplete or incorrect data, improving the overall user experience and data integrity.
Changes
handleStepfunction inMultistepWizard.tsxis now async and checks the validity of the form before proceeding.How Has This Been Tested?
Fixes Jira Issue
https://jira.esss.lu.se/browse/swap-4128
Depends On
Tests included/Docs Updated?